Some Minor Tweaks and New Module

[sephult]

Hello!!!!

[Transform MIDI]
So one of the things I believe needs to be modified in the Transform Midi is the Length.
Once a Length is specified one cannot turn this off and go back to the default.
This makes it so that the length cannot be ignored and whatever input is always controlled by it.
Whenever modified this takes over permanently.

[Logical Module Detect Open]
Another thing I am trying to find or thing a module should be implemented...
Logical modules do not respond to [-1], or an open condition. I think this would be a valuable option.
At the moment I am trying to detect an open state and am really stumped trying to find out how.
Even so I am thinking the amount of modules needed most likely makes this addition to the logical modules a valuable tool.
A button in the module settings for "detect open" would make a good addition.

[senso]

1) transform MIDI
Normally 0 length means ' set length disable'. But the queue of NOTE OFF (which have to be sent later), is not cleared. So I think that you want that this queue is cleared if the length returns to 0? I'll implement it.

2) detect flow [-1]
It's a good suggestion I'll implement it.

[sephult]

1) transform MIDI
Normally 0 length means ' set length disable'. But the queue of NOTE OFF (which have to be sent later), is not cleared. So I think that you want that this queue is cleared if the length returns to 0? I'll implement it.

Hi Senso!

I'm a little confused by your reply and unsure, so I'll try to clarify. I'm trying to understand what I wrote hahaha.


Current Operation of a Transform MIDI Length Parameter
----------------------------------------------------------------------------------------------------------
Apply a Transform MIDI - > NOTE ON and NOTE OFF are initially not controlled by Length Parameter (Length Bypassed)..
Once Length Parameter is modified, it always remains on. (The Problem)
Once Length Parameter is modified, NOTE OFF is always filtered from the input and generated by the Transform MIDI.
You cannot Bypass the Length Parameter and return to the original NOTE ON and NOTE OFF Bypass/Thru mode.
Length set to "0" does not bypass the Transform MIDI Length and allow input to output non-filtered. Just sets Length = 0ms.
----------------------------------------------------------------------

Summarized
Always remains on, cannot bypass once turned on. Always filters input NOTE OFF.

---------------------------------------------------------------------------------

Suggestion
------------------------------------------------------------
So here is what I see in regards to the Transform Length Parameter.
There are three options which I believe should exist. (MAX, CONST, BYPASS).
(Although I think it would be really cool in the future to implement a MIN/MAX Length).

Possibly a new-node combo-box, while the current Length Parameter stays the same?

1. Maximum Transform Length (Mix) -Defines the maximum NOTE Length, which can be overridden by a shorter playing duration.
- Input NOTE OFF is not filtered and will pass to the output.
- Queue will create duplicate NOTE OFF if user inputs NOTE OFF before Transformer queue timer expires. (One implementation)
- or "IF Equals" a current queue entry, then remove duplicate from queue to prevent duplicate output NOTE OFF. (Additional implementation)
2. Constant Transform Length - As done now by the Transformer, input NOTE OFF does not affect the length.
- Only generates NOTE OFF based on Length parameter of Transformer
- User played NOTE OFF is Filtered out and ignored.
3. Bypass Transform Length - Allows buffers to empty their current timers, but will just ignore the Length Parameter and pass MIDI
- MIDI NOTE ON / OFF will mirror from input to output unfiltered, and no new buffered timers will be done.
- Queue will continue to empty itself if remaining to prevent "Stuck Notes"
- Essentially just a Transform Length BYPASS

-s

[senso]

ok,
I'll implement mode 1 and 2
mode 3 is a little bit complex.

[damstraversaz]

that's some very interesting modes, I'm sure I will use it a lot.